Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genesis: use env to configure pre-genesis chain-id #3833

Merged
merged 6 commits into from
Sep 25, 2024
Merged

genesis: use env to configure pre-genesis chain-id #3833

merged 6 commits into from
Sep 25, 2024

Conversation

Fraccaman
Copy link
Member

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@brentstone brentstone added this to the v0.44.0 milestone Sep 20, 2024
tzemanovic
tzemanovic requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change lgtm, I'll just add some test that running a node, test-genesis and sign-genesis-txs are all picking this correctly

@tzemanovic tzemanovic force-pushed the fraccaman+tomas/pre-genesis-chain-id branch from 3de2462 to ba57011 Compare September 24, 2024 17:18
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.82%. Comparing base (be38d4c) to head (d269374).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/utils.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3833   +/-   ##
=======================================
  Coverage   72.82%   72.82%           
=======================================
  Files         338      338           
  Lines      104220   104227    +7     
=======================================
+ Hits        75897    75903    +6     
- Misses      28323    28324    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic mentioned this pull request Sep 25, 2024
Merged
3 tasks
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 25, 2024
mergify bot added a commit that referenced this pull request Sep 25, 2024
@mergify
Merge of #3833
4060c0b
@mergify mergify bot mentioned this pull request Sep 25, 2024
Closed
@mergify mergify bot merged commit fc5fe33 into main Sep 25, 2024
23 of 24 checks passed
@mergify mergify bot deleted the fraccaman+tomas/pre-genesis-chain-id branch September 25, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

Assignees
No one assigned
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fraccaman @tzemanovic @brentstone